diff options
| author | Ben Sima <ben@bensima.com> | 2025-11-27 14:06:56 -0500 |
|---|---|---|
| committer | Ben Sima <ben@bensima.com> | 2025-11-27 14:06:56 -0500 |
| commit | aad0175d6bb2b90d2c78a4a73844ae30ea6cefac (patch) | |
| tree | 8d2f65cd24da9572f8fb5e3916c28b1d88c092e9 /Omni/Jr/Web.hs | |
| parent | 64504c1cd5aba7f0ba31e4d6451bbf992a72b8f9 (diff) | |
Store and display Amp thread URL
The build and tests pass. Let me verify the changes are complete
by chec
1. ✅ The Amp thread URL is already parsed from amp output and
stored in 2. ✅ The display has been updated to show a "View in Amp
↗" button inste 3. ✅ CSS styling has been added for the button
(`.amp-thread-btn`) 4. ✅ Dark mode styles added for the button 5. ✅
Both instances of the URL display (in `renderExecutionDetails` and
The implementation is complete. The changes: -
[Omni/Jr/Web.hs](file:///home/ben/omni/Omni/Jr/Web.hs#L632-L637) - Cha
- [Omni/Jr/Web.hs](file:///home/ben/omni/Omni/Jr/Web.hs#L969-L974)
- Sam -
[Omni/Jr/Web/Style.hs](file:///home/ben/omni/Omni/Jr/Web/Style.hs#L531
-
[Omni/Jr/Web/Style.hs](file:///home/ben/omni/Omni/Jr/Web/Style.hs#L916
Task-Id: t-153.4
Diffstat (limited to 'Omni/Jr/Web.hs')
| -rw-r--r-- | Omni/Jr/Web.hs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Omni/Jr/Web.hs b/Omni/Jr/Web.hs index 6d0fa20..00e0c88 100644 --- a/Omni/Jr/Web.hs +++ b/Omni/Jr/Web.hs @@ -634,7 +634,7 @@ instance Lucid.ToHtml TaskDetailPage where Just url -> Lucid.div_ [Lucid.class_ "metric-row"] <| do Lucid.span_ [Lucid.class_ "metric-label"] "Amp Thread:" - Lucid.a_ [Lucid.href_ url, Lucid.target_ "_blank", Lucid.class_ "metric-value amp-link"] (Lucid.toHtml url) + Lucid.a_ [Lucid.href_ url, Lucid.target_ "_blank", Lucid.class_ "amp-thread-btn"] "View in Amp ↗" case (TaskCore.activityStartedAt act, TaskCore.activityCompletedAt act) of (Just start, Just end) -> @@ -971,7 +971,7 @@ instance Lucid.ToHtml TaskMetricsPartial where Just url -> Lucid.div_ [Lucid.class_ "metric-row"] <| do Lucid.span_ [Lucid.class_ "metric-label"] "Amp Thread:" - Lucid.a_ [Lucid.href_ url, Lucid.target_ "_blank", Lucid.class_ "metric-value amp-link"] (Lucid.toHtml url) + Lucid.a_ [Lucid.href_ url, Lucid.target_ "_blank", Lucid.class_ "amp-thread-btn"] "View in Amp ↗" case (TaskCore.activityStartedAt act, TaskCore.activityCompletedAt act) of (Just start, Just end) -> |