diff options
| author | Ben Sima <ben@bensima.com> | 2025-11-30 00:36:51 -0500 |
|---|---|---|
| committer | Ben Sima <ben@bensima.com> | 2025-11-30 00:36:51 -0500 |
| commit | 5fbcd92ff85bc9cc0b752888f6d3498aafea0b2a (patch) | |
| tree | 4bcae7c97bf81ecae696744cfcd84520e5db639d /Omni/Jr/Web.hs | |
| parent | d05ca4732710dd9cef7fffd998a03615ad2cb58c (diff) | |
Remove amp dependency entirely
The build and tests pass. Let me provide a summary of the changes made:
Removed the amp dependency entirely from the codebase:
- Removed `runAmp` function (was running amp subprocess) - Removed
`shouldUseEngine` function (env var check `JR_USE_ENGINE`) - Removed
`monitorLog` and `waitForFile` helpers (for amp.log parsing) - Removed
unused imports: `System.IO`, `Data.Text.IO` - Made `runWithEngine`
the default/only path - Updated error messages from "amp" to "engine" -
Renamed `ampOutput` parameter to `agentOutput` in `formatCommitMessage
- Added `Data.IORef` import for `newIORef`, `modifyIORef'`, `readIORef`
- Removed amp.log parsing code: `LogEntry`, `processLogLine`,
`updateFro - Removed unused imports: `Data.Aeson`,
`Data.ByteString.Lazy`, `Data.Te
- Renamed `activityAmpThreadUrl` to `activityThreadUrl`
- Updated field references from `activityAmpThreadUrl` to
`activityThrea - Updated UI label from "Amp Thread:" to "Session:"
- Updated comment from "amp completes" to "engine completes"
- Updated `Amp.execute` to `Engine.runAgent` - Updated logging section
to describe Engine callbacks instead of amp.lo - Updated integration
test guidance to mock Engine instead of amp binary
Task-Id: t-141.6
Diffstat (limited to 'Omni/Jr/Web.hs')
| -rw-r--r-- | Omni/Jr/Web.hs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Omni/Jr/Web.hs b/Omni/Jr/Web.hs index befda94..4e55c61 100644 --- a/Omni/Jr/Web.hs +++ b/Omni/Jr/Web.hs @@ -1725,11 +1725,11 @@ instance Lucid.ToHtml TaskDetailPage where renderAttempt totalAttempts (attemptNum, act) = do when (totalAttempts > 1) <| Lucid.div_ [Lucid.class_ "attempt-header"] (Lucid.toHtml ("Attempt " <> tshow attemptNum :: Text)) - case TaskCore.activityAmpThreadUrl act of + case TaskCore.activityThreadUrl act of Nothing -> pure () Just url -> Lucid.div_ [Lucid.class_ "metric-row"] <| do - Lucid.span_ [Lucid.class_ "metric-label"] "Amp Thread:" + Lucid.span_ [Lucid.class_ "metric-label"] "Session:" Lucid.a_ [Lucid.href_ url, Lucid.target_ "_blank", Lucid.class_ "amp-thread-btn"] "View in Amp ↗" case (TaskCore.activityStartedAt act, TaskCore.activityCompletedAt act) of @@ -2203,11 +2203,11 @@ instance Lucid.ToHtml TaskMetricsPartial where renderAttempt totalAttempts currentTime (attemptNum, act) = do when (totalAttempts > 1) <| Lucid.div_ [Lucid.class_ "attempt-header"] (Lucid.toHtml ("Attempt " <> tshow attemptNum :: Text)) - case TaskCore.activityAmpThreadUrl act of + case TaskCore.activityThreadUrl act of Nothing -> pure () Just url -> Lucid.div_ [Lucid.class_ "metric-row"] <| do - Lucid.span_ [Lucid.class_ "metric-label"] "Amp Thread:" + Lucid.span_ [Lucid.class_ "metric-label"] "Session:" Lucid.a_ [Lucid.href_ url, Lucid.target_ "_blank", Lucid.class_ "amp-thread-btn"] "View in Amp ↗" case (TaskCore.activityStartedAt act, TaskCore.activityCompletedAt act) of |
