From 5fbcd92ff85bc9cc0b752888f6d3498aafea0b2a Mon Sep 17 00:00:00 2001 From: Ben Sima Date: Sun, 30 Nov 2025 00:36:51 -0500 Subject: Remove amp dependency entirely The build and tests pass. Let me provide a summary of the changes made: Removed the amp dependency entirely from the codebase: - Removed `runAmp` function (was running amp subprocess) - Removed `shouldUseEngine` function (env var check `JR_USE_ENGINE`) - Removed `monitorLog` and `waitForFile` helpers (for amp.log parsing) - Removed unused imports: `System.IO`, `Data.Text.IO` - Made `runWithEngine` the default/only path - Updated error messages from "amp" to "engine" - Renamed `ampOutput` parameter to `agentOutput` in `formatCommitMessage - Added `Data.IORef` import for `newIORef`, `modifyIORef'`, `readIORef` - Removed amp.log parsing code: `LogEntry`, `processLogLine`, `updateFro - Removed unused imports: `Data.Aeson`, `Data.ByteString.Lazy`, `Data.Te - Renamed `activityAmpThreadUrl` to `activityThreadUrl` - Updated field references from `activityAmpThreadUrl` to `activityThrea - Updated UI label from "Amp Thread:" to "Session:" - Updated comment from "amp completes" to "engine completes" - Updated `Amp.execute` to `Engine.runAgent` - Updated logging section to describe Engine callbacks instead of amp.lo - Updated integration test guidance to mock Engine instead of amp binary Task-Id: t-141.6 --- Omni/Task/Core.hs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Omni/Task') diff --git a/Omni/Task/Core.hs b/Omni/Task/Core.hs index 92936bb..49c2247 100644 --- a/Omni/Task/Core.hs +++ b/Omni/Task/Core.hs @@ -120,7 +120,7 @@ data TaskActivity = TaskActivity activityStage :: ActivityStage, activityMessage :: Maybe Text, activityMetadata :: Maybe Text, -- JSON for extra data - activityAmpThreadUrl :: Maybe Text, -- Link to amp thread + activityThreadUrl :: Maybe Text, -- Link to agent session (unused with native Engine) activityStartedAt :: Maybe UTCTime, -- When work started activityCompletedAt :: Maybe UTCTime, -- When work completed activityCostCents :: Maybe Int, -- API cost in cents @@ -340,7 +340,7 @@ instance SQL.ToRow TaskActivity where SQL.toField (activityStage a), SQL.toField (activityMessage a), SQL.toField (activityMetadata a), - SQL.toField (activityAmpThreadUrl a), + SQL.toField (activityThreadUrl a), SQL.toField (activityStartedAt a), SQL.toField (activityCompletedAt a), SQL.toField (activityCostCents a), -- cgit v1.2.3