From 2203b9f08fc67d7229bb429ae136801b0dffd4f6 Mon Sep 17 00:00:00 2001 From: Ben Sima Date: Sat, 8 Nov 2025 16:26:30 -0500 Subject: Add testing and quality check requirements to AGENTS.md - Add coding convention: always include tests with new features and bug fixes - Add 'Required Checks Before Completing Tasks' section - Instruct agents to run 'bild --test' and 'lint' on modified namespaces - Require fixing all errors before marking tasks complete Completed tasks: - t-s9T0u1: Add testing guidance - t-v2w3x4: Add build/lint instructions Amp-Thread-ID: https://ampcode.com/threads/T-85f4ee29-a529-4f59-ac6f-6ffec75b6a56 Co-authored-by: Amp --- AGENTS.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'AGENTS.md') diff --git a/AGENTS.md b/AGENTS.md index e30b01a..9450a0a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -316,6 +316,7 @@ repl.sh --bash Omni/Log.py # Start bash shell for namespace 1. **Test interface**: Every program must accept `test` as a first argument to run its test suite 2. **Entrypoint naming**: The entrypoint for every program shall be called `main` +3. **Always include tests**: Every new feature and bug fix must include tests. No code should be committed without corresponding test coverage ## Git Workflow @@ -380,6 +381,20 @@ git submit 3. **Rebase and clean up history** - Use `git commit --amend` and `git restack` to keep history clean 4. **Test before committing** - Run `bild --test` and `lint` on affected namespaces +### Required Checks Before Completing Tasks + +After completing a task, **always** run these commands for the namespace(s) you modified: + +```bash +# Run tests +bild --test Omni/YourNamespace.hs + +# Run linter +lint Omni/YourNamespace.hs +``` + +**Fix all reported errors** related to your changes before marking the task as complete. This ensures code quality and prevents breaking the build for other contributors. + ## Future Enhancements Planned features (not yet implemented): -- cgit v1.2.3