| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
|
|
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
|
|
https: //ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
|
|
|
|
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
The task was to update `Omni/Task/Core.hs` to exclude tasks with
`taskType == Epic` from the `task ready` command.
I have: 1. Analyzed the codebase and located the `getReadyTasks`
function in `Omni/Task/Core.hs`. 2. Created a reproduction script to
confirm that Epics were appearing in the `ready` list. 3. Modified
`Omni/Task/Core.hs` to add `taskType task /= Epic` condition in
`getReadyTasks`. 4. Added a unit test in `Omni/Task.hs` to verify
that Epics are excluded from ready tasks. 5. Ran tests using `bild
--test Omni/Task.hs` and verified they pass. 6. Ran `lint Omni/Task.hs
Omni/Task/Core.hs` to ensure code quality.
The changes are verified and ready.
```haskell 397: isReady task = 398: taskType task /= Epic 399: && not
(isParent (taskId task)) 400: && all (`elem` doneIds) (blockingDepIds
task) ```
Added a new test case: ```haskell
Test.unit "ready tasks exclude epics" <| do
epic <- createTask "Epic task" Epic Nothing Nothing P2 []
Nothing ready <- getReadyTasks (taskId epic `notElem` map
taskId ready) Test.@?= True,
```
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
|
|
The task "Add Approved status to Omni/Task" has been implemented.
**Changes made:**
1. **`Omni/Task/Core.hs`**:
* Updated `Status` enum to include `Approved`. * Updated
`TaskStats` record to include `approvedTasks` count. *
Updated `getTaskStats` to count `Approved` tasks. * Updated
`showTaskStats` to display the count. * Updated `printTreeNode'`
and `printTask` to visualize `Approved` status with `[+]` symbol
and green color.
2. **`Omni/Task.hs`**:
* Updated `help` documentation to list `approved` as a valid
status. * Updated `list` command to support filtering by
`--status=approved`. * Updated `update` command to support
setting status to `approved`. * Added unit tests for the new
CLI functionality.
**Verification:** * Ran `bild --test Omni/Task.hs` (with `CODEROOT`
explicitly set to current directory to bypass build caching issue)
and all tests passed. * Manually verified creating a task, updating
it to `approved`, showing it, viewing the tree, and viewing stats
using the compiled binary.
**Note on Build Environment:** * I encountered an issue where `bild`
would not rebuild because `CODEROOT` was pointing to `/home/ben/omni`
instead of the worker workspace `/home/ben/omni-worker-3`. I
temporarily set `export CODEROOT=$(pwd)` to successfully build and
verify the changes.
The `Approved` status is now fully supported in the Task core and CLI,
enabling the review workflow described in the plan.
|
|
|
|
|
|
|
|
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
Refactored `AGENTS.md` to be a concise cheat sheet by:
1. Moving detailed examples of "Forbidden Patterns" and "Bug
Discovery" to `Omni/Task/README.md`. 2. Moving "Coding Conventions"
(Always include tests, No TODOs, Fast typechecking) to `README.md`. 3.
Removing "About Omnirepo" and "Source Layout" sections from `AGENTS.md`
as they are duplicative of `README.md`. 4. Condensing `AGENTS.md`
to contain only Critical Rules, a short Session Checklist/Cheat
Sheet, and pointers to the detailed READMEs (`Omni/Task/README.md`,
`Omni/Bild/README.md`, `Omni/Ide/README.md`, `README.md`).
Verified that detailed documentation exists in the respective
namespaces and passed linting.
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-ca3b086b-5a85-422a-b13d-256784c04221
Co-authored-by: Amp <amp@ampcode.com>
|
|
I have successfully refactored `AGENTS.md` to be more concise by
moving detailed documentation to separate README files in their
respective namespaces.
**Changes made:** 1. **Created `Omni/Task/README.md`**: Contains
the detailed "Task Manager for AI Agents" documentation. 2.
**Created `Omni/Bild/README.md`**: Contains the "Bild" build tool
documentation and instructions for adding new dependencies. 3.
**Created `Omni/Ide/README.md`**: Contains the "Development Tools"
(run.sh, lint, etc.) and "Git Workflow" documentation. 4. **Updated
`AGENTS.md`**:
* Retained critical rules ("Important Rules for AI Agents"),
"About Omnirepo", and "Coding Conventions". * Replaced the
moved sections with a "Documentation" section containing links
to the new README files. * Used relative paths for links to
ensure portability.
**Verification:** * Ran `bild --test Omni/Task.hs` and `bild --test
Omni/Bild.hs` to ensure no regressions were introduced in the touched
namespaces.
The codebase is now cleaner with documentation distributed near
the code it describes, and `AGENTS.md` is now a focused entry point
for agents.
|
|
The task to automate the git commit template configuration has been
completed.
**Changes Implemented:** 1. **Created `.gitmessage`**: Added
a standard commit message template to the repository root. This
template encourages following the "50/72 rule" for commit messages
(50-char summary, 72-char wrapped body) and provides sections for
explanation and links. 2. **Updated `Omni/Task.hs`**: Modified
the `init` command handler in the task manager CLI. Now, when `task
init` is run, it executes `git config commit.template .gitmessage`
in addition to initializing the task database.
**Verification:** - Ran `bild --test Omni/Task.hs` to verify that the
changes compile correctly and do not break existing tests. - The
`task init` command is the standard entry point for setting up the
repository environment (as per `AGENTS.md`), ensuring that all users
(human and agents) running the setup will automatically get the commit
template configured.
**Files Created/Modified:** - `Omni/Task.hs` (modified) - `.gitmessage`
(created)
The changes are ready for the system to commit.
[Omni/Task.hs](file:///home/ben/omni-worker-3/Omni/Task.hs)
[.gitmessage](file:///home/ben/omni-worker-3/.gitmessage)
|
|
The task was to verify that lowercase task IDs are accepted and do
not clash with old tasks.
I have verified this by: 1. **Analyzing the codebase**: I explored
`Omni/Task.hs` and `Omni/Task/Core.hs` to understand how task
IDs are generated, stored, and compared. I found that `matchesId`
implements case-insensitive comparison, which means `t-abc` and
`t-ABC` are effectively the same task ID in lookup operations. 2.
**Updating Core Logic**: I modified `Omni/Task/Core.hs` (via a
sub-agent operation that I verified) to:
* Implement `toBase36` for ID generation, ensuring new
IDs use only lowercase characters (0-9, a-z). * Implement
`generateUniqueId` which checks for collisions against existing
tasks (case-insensitively) before assigning a new ID. * Update
`createTask` to use `generateUniqueId` instead of `generateId`.
3. **Adding Tests**: I modified `Omni/Task.hs` to add unit tests
that explicitly verify:
* Lowercase task IDs can be created and found. * `generateId`
(now unique and lowercase) produces valid IDs that can be found.
4. **Verifying**: I ran `bild --test Omni/Task.hs` and confirmed
that all tests pass, including the new ones.
The system now generates lowercase IDs by default and actively
prevents collisions with any existing mixed-case IDs, satisfying
the requirements.
Task Status: Done (Ready to be closed by system/user) Changes are
committed to local files.
|
|
Amp-Thread-ID:
https://ampcode.com/threads/T-a65df310-235f-4d63-9f78-4affc537b80b
Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
